PHP 8.5 | Tokenizer/PHP: polyfill the (void) cast #1325
Merged
+644
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
php-8.5/1306-tokenizer-php-polyfill-void-cast
branch
from
392784d to
be46b97
Compare
Member
Author
|
Rebased without changes to get a passing build after #1326 |
As part of the RFC for the `#[NoDiscard]` attribute, a new typecast `(void)` has been introduced. This commit polyfills this new token for PHP < 8.5. Includes tests covering the complete set of type casts, even though the PHPCS Tokenizer only handles the `(void)` cast. Reason being, that PHP has deprecated and removed some casts, like `(unset)`, and their token constants may be removed from PHP Core at some point in the future. These tests should serve as a warning system for that eventuality. Ref: https://wiki.php.net/rfc/marking_return_value_as_important#void_cast_to_suppress_the_warning
Member
Author
|
Rebased without changes, other than squashing the "fix up" commits into their atomic ancestors. |
jrfnl
force-pushed
the
php-8.5/1306-tokenizer-php-polyfill-void-cast
branch
from
1f25f50 to
dc30ab9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PHP 8.5 | Tokenizer/PHP: polyfill the (void) cast
As part of the RFC for the
#[NoDiscard]attribute, a new typecast(void)has been introduced.This commit polyfills this new token for PHP < 8.5.
Includes tests covering the complete set of type casts, even though the PHPCS Tokenizer only handles the
(void)cast.Reason being, that PHP has deprecated and removed some casts, like
(unset), and their token constants may be removed from PHP Core at some point in the future. These tests should serve as a warning system for that eventuality.Ref: https://wiki.php.net/rfc/marking_return_value_as_important#void_cast_to_suppress_the_warning
Various sniffs: add tests with PHP 8.5 (void) cast
Suggested changelog entry
Added
(void)cast.T_VOID_CASTtoken has been added to theTokens::CAST_TOKENSarray.Related issues/external references
Related to #1306